Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed sign/verify inconsistencies. #2

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fixed sign/verify inconsistencies. #2

wants to merge 8 commits into from

Conversation

eembc
Copy link
Collaborator

@eembc eembc commented Jan 13, 2023

The signatures for RSA were incorrect per PCKS#1. Generated new keys and signatures for EcDSA, Ed25519, and RSA. Re-did the code for wolfSSL sign and verify as well to use wc_SignatureVerify and wc_SignatureGenerate.

@petertorelli
Fixed sign/verify inconsistencies.
2cc2e98 
The signatures for RSA were incorrect per PCKS#1. Generated new
keys and signatures for EcDSA, Ed25519, and RSA. Re-did the code
for wolfSSL sign and verify as well to use wc_SignatureVerify
and wc_SignatureGenerate.
ruuddw
ruuddw requested changes Jan 13, 2023
View reviewed changes
Copy link

@ruuddw ruuddw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. The PKCS#1 v1.5 fix looks good, but the change to sign/verify functions that now perform (pre)hashing as part of the functions should be reverted.

examples/selfhosted/keys.h Show resolved Hide resolved
examples/selfhosted/profile/wolfssl_th_api/th_ecdsa.c Outdated Show resolved Hide resolved
examples/selfhosted/profile/wolfssl_th_api/th_ecdsa.c Outdated Show resolved Hide resolved
examples/selfhosted/profile/wolfssl_th_api/th_rsa.c Outdated Show resolved Hide resolved
@petertorelli
Copy link
Member

Awaiting resolution of wolfSSL/wolfssl#5981 after which I'll remove the manual encoding and then merge. I'll also change the const assignments in the keys.h file to address errors in MSVC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruuddw ruuddw ruuddw requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eembc @petertorelli @ruuddw